Update inflate/deflate with right flag (Z_FINISH, no Z_SYNC_FLUSH)

include/fulfillment_item.h

@@ -34,6 +34,12 @@ namespace gourou
     class FulfillmentItem
     {
     public:
+	/**
+	 * @brief Main constructor. Not to be called by user
+	 *
+	 * @param doc   Fulfill reply
+	 * @param user  User pointer
+	 */
 	FulfillmentItem(pugi::xml_document& doc, User* user);
 
 	/**
@@ -59,6 +65,7 @@ namespace gourou
 	std::string getResource();
 
     private:
+	pugi::xml_document fulfillDoc;
 	pugi::xml_node metadatas;
 	pugi::xml_document rights;
 	std::string downloadURL;

include/libgourou.h

@@ -40,7 +40,7 @@
 #define ACS_SERVER              "http://adeactivate.adobe.com/adept"
 #endif
 
-#define LIBGOUROU_VERSION       "0.4.2"
+#define LIBGOUROU_VERSION       "0.4.4"
 
 namespace gourou
 {

src/fulfillment_item.cpp

@@ -24,9 +24,11 @@
 namespace gourou
 {
     FulfillmentItem::FulfillmentItem(pugi::xml_document& doc, User* user)
+	: fulfillDoc()
     {
-	metadatas = doc.select_node("//metadata").node();
+	fulfillDoc.reset(doc); /* We must keep a copy */
-
+	metadatas = fulfillDoc.select_node("//metadata").node();
+	
 	if (!metadatas)
 	    EXCEPTION(FFI_INVALID_FULFILLMENT_DATA, "No metadata tag in document");
 	
@@ -49,7 +51,7 @@ namespace gourou
 	
 	buildRights(licenseToken, user);
     }
-
+   
     void FulfillmentItem::buildRights(const pugi::xml_node& licenseToken, User* user)
     {
 	pugi::xml_node decl = rights.append_child(pugi::node_declaration);

src/libgourou.cpp

@@ -599,9 +599,13 @@ namespace gourou
 
 	std::string rightsStr = item->getRights();
 
-	if (headers.count("Content-Type") && headers["Content-Type"] == "application/pdf")
+	if (item->getMetadata("format").find("application/pdf") != std::string::npos)
 	    res = PDF;
 
+	if (headers.count("Content-Type") &&
+	    headers["Content-Type"].find("application/pdf") != std::string::npos)
+	    res = PDF;
+	    
 	if (res == EPUB)
 	{
 	    void* handler = client->zipOpen(path);

utils/Makefile

@@ -3,9 +3,11 @@ TARGETS=acsmdownloader adept_activate
 
 CXXFLAGS=-Wall `pkg-config --cflags Qt5Core Qt5Network` -fPIC -I$(ROOT)/include -I$(ROOT)/lib/pugixml/src/
 
+STATIC_DEP=
 LDFLAGS=`pkg-config --libs Qt5Core Qt5Network` -L$(ROOT) -lcrypto -lzip -lz
+
 ifneq ($(STATIC_UTILS),)
-LDFLAGS += $(ROOT)/libgourou.a
+STATIC_DEP = $(ROOT)/libgourou.a
 else
 LDFLAGS += -lgourou
 endif
@@ -18,10 +20,10 @@ endif
 
 all: $(TARGETS)
 
-acsmdownloader: drmprocessorclientimpl.cpp acsmdownloader.cpp 
+acsmdownloader: drmprocessorclientimpl.cpp acsmdownloader.cpp $(STATIC_DEP)
 	$(CXX) $(CXXFLAGS) $^ $(LDFLAGS) -o $@
 
-adept_activate: drmprocessorclientimpl.cpp adept_activate.cpp 
+adept_activate: drmprocessorclientimpl.cpp adept_activate.cpp $(STATIC_DEP) 
 	$(CXX) $(CXXFLAGS) $^ $(LDFLAGS) -o $@
 
 clean:

utils/acsmdownloader.cpp

@@ -105,6 +105,11 @@ public:
 		    filename = item->getMetadata("title");
 		    if (filename == "")
 			filename = "output";
+		    else
+		    {
+			// Remove invalid characters
+			std::replace(filename.begin(), filename.end(), '/', '_');
+		    }
 		}
 		else
 		    filename = outputFile;

utils/adept_activate.cpp

@@ -152,7 +152,7 @@ static void usage(const char* cmd)
     std::cout << "  " << "-H|--hobbes-version" << "\t"<< "Force RMSDK version to a specific value (default: version of current librmsdk)" << std::endl;
     std::cout << "  " << "-r|--random-serial" << "\t"<< "Generate a random device serial (if not set, it will be dependent of your current configuration)" << std::endl;
     std::cout << "  " << "-v|--verbose"    << "\t\t" << "Increase verbosity, can be set multiple times" << std::endl;
-    std::cout << "  " << "-V|--version"         << "\t\t" << "Display libgourou version" << std::endl;
+    std::cout << "  " << "-V|--version"    << "\t\t" << "Display libgourou version" << std::endl;
     std::cout << "  " << "-h|--help"       << "\t\t" << "This help" << std::endl;
 
     std::cout << std::endl;
@@ -184,7 +184,7 @@ int main(int argc, char** argv)
 	    {"hobbes-version",required_argument, 0,  'H' },
 	    {"random-serial", no_argument,       0,  'r' },
 	    {"verbose",       no_argument,       0,  'v' },
-	    {"version",          no_argument,       0,  'V' },
+	    {"version",       no_argument,       0,  'V' },
 	    {"help",          no_argument,       0,  'h' },
 	    {0,               0,                 0,  0 }
 	};

utils/drmprocessorclientimpl.cpp

@@ -441,26 +441,31 @@ void DRMProcessorClientImpl::inflate(std::string data, gourou::ByteArray& result
 
     int ret = inflateInit2(&infstream, wbits);
 
-    ret = ::inflate(&infstream, Z_SYNC_FLUSH);
+    if (ret != Z_OK)
+	EXCEPTION(gourou::CLIENT_ZIP_ERROR, infstream.msg);
+
+    ret = ::inflate(&infstream, Z_FINISH);
     while (ret == Z_OK || ret == Z_STREAM_END)
     {
 	result.append(buffer, dataSize-infstream.avail_out);
-	if (ret == Z_STREAM_END) break;
+	if ((ret == Z_OK && infstream.avail_out != 0) || ret == Z_STREAM_END)
+	    break;
 	infstream.avail_out = (uInt)dataSize; // size of output
 	infstream.next_out = (Bytef *)buffer; // output char array
-	ret = ::inflate(&infstream, Z_SYNC_FLUSH);
+	ret = ::inflate(&infstream, Z_FINISH);
     }
 
-    inflateEnd(&infstream);
+    if (ret == Z_STREAM_END)
+	ret = deflateEnd(&infstream);
 
     delete[] buffer;
 
-    if (ret != Z_OK && ret != Z_STREAM_END && ret != Z_BUF_ERROR)
+    if (ret != Z_OK && ret != Z_STREAM_END)
 	EXCEPTION(gourou::CLIENT_ZIP_ERROR, zError(ret));
 }
 	
 void DRMProcessorClientImpl::deflate(std::string data, gourou::ByteArray& result,
-			     int wbits, int compressionLevel)
+				     int wbits, int compressionLevel)
 {
     unsigned int dataSize = data.size();
     unsigned char* buffer = new unsigned char[dataSize];
@@ -479,20 +484,25 @@ void DRMProcessorClientImpl::deflate(std::string data, gourou::ByteArray& result
     int ret = deflateInit2(&defstream, Z_DEFAULT_COMPRESSION, Z_DEFLATED, wbits,
 			   compressionLevel, Z_DEFAULT_STRATEGY);
 
-    ret = ::deflate(&defstream, Z_SYNC_FLUSH);
+    if (ret != Z_OK)
+	EXCEPTION(gourou::CLIENT_ZIP_ERROR, defstream.msg);
+
+    ret = ::deflate(&defstream, Z_FINISH);
     while (ret == Z_OK || ret == Z_STREAM_END)
     {
 	result.append(buffer, dataSize-defstream.avail_out);
-	if (ret == Z_STREAM_END) break;
+	if ((ret == Z_OK && defstream.avail_out != 0) || ret == Z_STREAM_END)
+	    break;
 	defstream.avail_out = (uInt)dataSize; // size of output
 	defstream.next_out = (Bytef *)buffer; // output char array
-	ret = ::deflate(&defstream, Z_SYNC_FLUSH);
+	ret = ::deflate(&defstream, Z_FINISH);
     }
-   
+
-    deflateEnd(&defstream);
+    if (ret == Z_STREAM_END)
+	ret = deflateEnd(&defstream);
 
     delete[] buffer;
 
-    if (ret != Z_OK && ret != Z_STREAM_END && ret != Z_BUF_ERROR)
+    if (ret != Z_OK && ret != Z_STREAM_END)
 	EXCEPTION(gourou::CLIENT_ZIP_ERROR, zError(ret));
 }